Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more validation to Rite Aid API #547

Merged
merged 10 commits into from
Feb 2, 2022
Merged

Add more validation to Rite Aid API #547

merged 10 commits into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. Separate raw data loading and formatting in Rite Aid API

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    eb73382 View commit details
    Browse the repository at this point in the history

  2. Validate slot counts from Rite Aid's API 

    - If the total slots is unreasonably high, log a warning, but don't fail.
- If the total slots is less than the available slots, throw an error (something is way broken).

Along the way, this amends the overall flow to match more recently written sources, where an exception formatting a single location doesn't stop other locations from being formatted and sent.
    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    acab328 View commit details
    Browse the repository at this point in the history

  3. Add schema checking for Rite Aid API 

    Also adds parsing for phone numbers, because I was foolish enough to try checking the phone number pattern in the schema, and discovered that leading zeroes on the local part of the phone numbers are missing in Rite Aid's data (!!!).
    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    77f5a80 View commit details
    Browse the repository at this point in the history

  4. Update fixture file to current API format

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1dd14ba View commit details
    Browse the repository at this point in the history

  5. Clean up Rite Aid errors, fixes #537

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    452e670 View commit details
    Browse the repository at this point in the history

  6. Genericize the mocks for logging

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    768dd42 View commit details
    Browse the repository at this point in the history

  7. Add helpful comments, remove unhelpful ones

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    324bf8a View commit details
    Browse the repository at this point in the history

  8. Fix lint error 

    I could have sworn I tested the previous approach, but clearly not. :\
    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    632bdb2 View commit details
    Browse the repository at this point in the history

  9. Use pre-node-16-style strict assertions

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    0f3a199 View commit details
    Browse the repository at this point in the history

  10. Incredibly, the XHR API has the phone number problem, too

    @Mr0grog
    Mr0grog committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    26eb461 View commit details
    Browse the repository at this point in the history