Change _.uniq to only be called once

usds · Jul 13, 2018 · 086676b · 086676b
1 parent 2b5f1a9
commit 086676b
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/src/js/helpers.js b/src/js/helpers.js
@@ -25,19 +25,13 @@ export function getActivePages(pages, data) {
 }
 
 export function getActiveProperties(activePages) {
-  let allProperties = [];
-  activePages.map(page => {
+  const allProperties = [];
+  activePages.forEach(page => {
     if (page.schema) {
-      allProperties = _.uniq(_.concat(Object.keys(page.schema.properties), allProperties));
+      allProperties.push(...Object.keys(page.schema.properties));
     }
-    return allProperties;
   });
-
-  return allProperties;
-
-  // return new Set([].concat(
-  //   ...activePages.map(page => Object.keys(page.schema.properties))
-  // ));
+  return _.uniq(allProperties);
 }
 
 export function getInactivePages(pages, data) {