Skip to content

chore: improvements peter/feat-revive branch #2834

chore: improvements peter/feat-revive branch

chore: improvements peter/feat-revive branch #2834

Triggered via pull request October 23, 2024 20:23
Status Skipped
Total duration 3s
Artifacts

dependabot-auto-merge.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

12 errors
using `map_err` over `inspect_err`: crates/build/src/lib.rs#L768
error: using `map_err` over `inspect_err` --> crates/build/src/lib.rs:768:75 | 768 | local_build(&crate_metadata, &optimization_passes, &args).map_err( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect help: try | 768 ~ local_build(&crate_metadata, &optimization_passes, &args).inspect_err( 769 | |e| { 770 | // build error -> bundle is stale 771 ~ clean_metadata(); |
useless use of `format!`: crates/build/src/lib.rs#L346
error: useless use of `format!` --> crates/build/src/lib.rs:346:22 | 346 | Some(format!("{}", rustflags)), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `rustflags.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-D clippy::useless-format` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
using `map_err` over `inspect_err`: crates/build/src/lib.rs#L768
error: using `map_err` over `inspect_err` --> crates/build/src/lib.rs:768:75 | 768 | local_build(&crate_metadata, &optimization_passes, &args).map_err( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect help: try | 768 ~ local_build(&crate_metadata, &optimization_passes, &args).inspect_err( 769 | |e| { 770 | // build error -> bundle is stale 771 ~ clean_metadata(); |
useless use of `format!`: crates/build/src/lib.rs#L346
error: useless use of `format!` --> crates/build/src/lib.rs:346:22 | 346 | Some(format!("{}", rustflags)), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `rustflags.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-D clippy::useless-format` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
using `map` over `inspect`: crates/build/src/docker.rs#L221
error: using `map` over `inspect` --> crates/build/src/docker.rs:221:43 | 221 | build_result.metadata_result.as_mut().map(|m| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `-D clippy::manual-inspect` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]` help: try | 221 ~ build_result.metadata_result.as_mut().inspect(|m| { 222 | m.dest_bundle = host_folder.join( ... 232 | .expect("cannot strip prefix"), 233 ~ ); |
using `map_err` over `inspect_err`: crates/build/src/lib.rs#L768
error: using `map_err` over `inspect_err` --> crates/build/src/lib.rs:768:75 | 768 | local_build(&crate_metadata, &optimization_passes, &args).map_err( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect help: try | 768 ~ local_build(&crate_metadata, &optimization_passes, &args).inspect_err( 769 | |e| { 770 | // build error -> bundle is stale 771 ~ clean_metadata(); |
useless use of `format!`: crates/build/src/lib.rs#L346
error: useless use of `format!` --> crates/build/src/lib.rs:346:22 | 346 | Some(format!("{}", rustflags)), | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `rustflags.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `-D clippy::useless-format` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_format)]`
unused variable: `extra_lints`: crates/build/src/lib.rs#L830
error: unused variable: `extra_lints` --> crates/build/src/lib.rs:830:9 | 830 | extra_lints, | ^^^^^^^^^^^- | | | help: try removing the field | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`
using `map` over `inspect`: crates/build/src/docker.rs#L221
error: using `map` over `inspect` --> crates/build/src/docker.rs:221:43 | 221 | build_result.metadata_result.as_mut().map(|m| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `-D clippy::manual-inspect` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]` help: try | 221 ~ build_result.metadata_result.as_mut().inspect(|m| { 222 | m.dest_bundle = host_folder.join( ... 232 | .expect("cannot strip prefix"), 233 ~ ); |
unused variable: `extra_lints`: crates/build/src/lib.rs#L830
error: unused variable: `extra_lints` --> crates/build/src/lib.rs:830:9 | 830 | extra_lints, | ^^^^^^^^^^^- | | | help: try removing the field | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`
using `map` over `inspect`: crates/build/src/docker.rs#L221
error: using `map` over `inspect` --> crates/build/src/docker.rs:221:43 | 221 | build_result.metadata_result.as_mut().map(|m| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `-D clippy::manual-inspect` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]` help: try | 221 ~ build_result.metadata_result.as_mut().inspect(|m| { 222 | m.dest_bundle = host_folder.join( ... 232 | .expect("cannot strip prefix"), 233 ~ ); |
unused variable: `extra_lints`: crates/build/src/lib.rs#L830
error: unused variable: `extra_lints` --> crates/build/src/lib.rs:830:9 | 830 | extra_lints, | ^^^^^^^^^^^- | | | help: try removing the field | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`