Improvements for production deployment check (#1562)

* Improve comments

* Default to `n`

* Use correct capitalization

* Improve comments

* Use spelling consistent with rest of codebase

* Adapt to conventions of surrounding codebase

* Use `N`

crates/cargo-contract/src/cmd/info.rs

@@ -75,7 +75,7 @@ pub struct InfoCommand {
         default_value = "ws://localhost:9944"
     )]
     url: url::Url,
-    /// A name of a production chain to upload or instantiate the contract on.
+    /// Name of a production chain to upload or instantiate the contract on.
     #[clap(name = "chain", long, conflicts_with = "url")]
     chain: Option<ProductionChain>,
     /// Export the instantiate output in JSON format.

crates/cargo-contract/src/cmd/mod.rs

@@ -128,7 +128,7 @@ pub struct CLIExtrinsicOpts {
     /// Before submitting a transaction, do not ask the user for confirmation.
     #[clap(short('y'), long)]
     skip_confirm: bool,
-    /// A name of a production chain to upload or instantiate the contract on.
+    /// Name of a production chain to upload or instantiate the contract on.
     #[clap(name = "chain", long, conflicts_with = "url")]
     chain: Option<ProductionChain>,
 }
@@ -330,16 +330,16 @@ pub fn prompt_confirm_unverifiable_upload(chain: &str) -> Result<()> {
     println!(
         "{} ({}): ",
         "\nContinue?".bright_white().bold(),
-        "Y/n".bright_white().bold()
+        "y/N".bright_white().bold()
     );
 
     let mut buf = String::new();
     io::stdout().flush()?;
     io::stdin().read_line(&mut buf)?;
     match buf.trim().to_lowercase().as_str() {
-        // default is 'y'
-        "y" | "" => Ok(()),
-        "n" => Err(anyhow!("Upload canceled!")),
+        // default is 'n'
+        "y" => Ok(()),
+        "n" | "" => Err(anyhow!("Upload cancelled!")),
         c => Err(anyhow!("Expected either 'y' or 'n', got '{}'", c)),
     }
 }

crates/cargo-contract/src/cmd/rpc.rs

@@ -41,7 +41,7 @@ pub struct RpcCommand {
         default_value = "ws://localhost:9944"
     )]
     url: url::Url,
-    /// A name of a production chain to upload or instantiate the contract on.
+    /// Name of a production chain to upload or instantiate the contract on.
     #[clap(name = "chain", long, conflicts_with = "url")]
     chain: Option<ProductionChain>,
     /// Export the call output in JSON format.

crates/extrinsics/src/contract_artifacts.rs

@@ -170,8 +170,9 @@ impl ContractArtifacts {
             .context("Failed to deserialize ink project metadata from contract metadata")
     }
 
-    /// Return true if the image is verifiable.
-    /// If the metadata can not be extracted then we assume that it can't be verified.
+    /// Returns `true` if the image is verifiable.
+    ///
+    /// If the metadata cannot be extracted we assume that it can't be verified.
     pub fn is_verifiable(&self) -> bool {
         match self.metadata() {
             Ok(m) => m.image.is_some(),

crates/extrinsics/src/extrinsic_opts.rs

@@ -158,10 +158,10 @@ where
         url_to_string(&self.url)
     }
 
-    /// Get the chain name and its URL endpoint.
-    /// If the user specify the endpoint manually,
-    /// but it still appears to be the production chain,
-    /// we still convert it.
+    /// Returns the chain name and its URL endpoint.
+    ///
+    /// If the user specified the endpoint URL manually we'll attempt to
+    /// convert it into one of the pre-defined production chains.
     pub fn chain_and_endpoint(&self) -> (Chain, String) {
         if let Some(chain) = &self.chain {
             (
@@ -181,6 +181,9 @@ where
         }
     }
 
+    /// Returns `true` if the image is verifiable.
+    ///
+    /// If the metadata cannot be extracted we assume that it can't be verified.
     pub fn is_verifiable(&self) -> Result<bool> {
         Ok(self.contract_artifacts()?.is_verifiable())
     }

crates/extrinsics/src/prod_chains.rs

@@ -19,8 +19,10 @@
 
 use std::str::FromStr;
 
-/// Macro to generate enums with production chains and their respective endpoints
-/// and generate required trait implementation
+/// This macro generates enums with the pre-defined production chains and their respective
+/// endpoints.
+///
+/// It also generates the required trait implementations.
 macro_rules! define_chains {
     (
         $(#[$($attrs:tt)*])*
@@ -76,7 +78,7 @@ macro_rules! define_chains {
 }
 
 define_chains! {
-    /// A list of all production chains where the contract can be deployed to.
+    /// List of production chains where the contract can be deployed to.
     pub enum ProductionChain {
         AlephZero = "wss://ws.azero.dev:443",
         Astar = "wss://rpc.astar.network:443",