CI optimization: build workflow matrix dynamically #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejparity
requested review from
AndWeHaveAPlan,
altaua,
alvicsam,
ascjones,
cmichi,
mateo-moon and
rcny
alvicsam
approved these changes
Oct 18, 2023
altaua
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings even more optimisations to GHA workflow compared to #45
Now I implemented dynamic matrix creation for the
checkjob. It is looking for the PR changes and checks only changed contracts. This will speedup feedback loop even more than previous optimisation:Also, there is no need anymore to manually update list of the contracts in a workflow.
Example - PR touches 5 contracts:
Without cache - ~44min
With cache - ~7min
Related to https://github.com/paritytech/ci_cd/issues/553