Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ink! 5 #60

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Update to ink! 5 #60

merged 10 commits into from
Feb 20, 2024

Conversation

smiasojed
Copy link
Contributor

@smiasojed smiasojed commented Jan 25, 2024

Update examples to comply with ink! 5

@smiasojed
Copy link
Contributor Author

Due to a missing dependency on uapi, which has not been released with ink yet, there are expected failures for the given contracts: erc1155, call-runtime, multisig, upgradeable-contracts. (8 failures in CI)

@smiasojed smiasojed marked this pull request as ready for review January 29, 2024 12:27
@cmichi
Copy link
Collaborator

cmichi commented Jan 31, 2024

Due to a missing dependency on uapi, which has not been released with ink yet, there are expected failures for the given contracts: erc1155, call-runtime, multisig, upgradeable-contracts. (8 failures in CI)

@pgherveou has published ink-pallet-contracts-uapi by now, there'll be a re-release under a different name soon, but could you use the already published crate so that we see CI running?

@smiasojed
Copy link
Contributor Author

smiasojed commented Jan 31, 2024

@cmichi, I need ink! version which is using ink-pallet-contracts-uapi crate, so the option could be to set contracts deps on ink! from master branch., but in this case I need also to apply the change call -> call_builder. WDYT?

@smiasojed smiasojed merged commit f19fcdc into main Feb 20, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants