Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ink 5.0.0-rc2 #63

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Update to ink 5.0.0-rc2 #63

merged 9 commits into from
Mar 6, 2024

Conversation

smiasojed
Copy link
Contributor

@smiasojed smiasojed commented Mar 1, 2024

Update to ink 5.0.0-rc2
Update CI

@smiasojed smiasojed marked this pull request as ready for review March 4, 2024 10:50
@ascjones
Copy link
Collaborator

ascjones commented Mar 4, 2024

However, there seems to be a missing entry, such as trait-dyn-cross-contract-calls. Should this be added there, or was it intentionally omitted?"

I'm not sure, if they should be included in the build matrix and are currently not then we should add it here or elsewhere

@@ -8,7 +8,7 @@ Have a look at the different examples to better understand how to use ink! to bu

### Can I add a new example here?

Please don't add them here, but create a Pull Request to the `integration-tests` folder in [the ink! repository](https://github.com/paritytech/ink) instead.
Please don't add them here, but create a Pull Request to the `integration-tests/public` folder in [the ink! repository](https://github.com/paritytech/ink) instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch ;-).

@smiasojed smiasojed merged commit 46b1edb into main Mar 6, 2024
72 checks passed
@cmichi cmichi deleted the sm/ink-5.0.0-rc.2 branch March 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants