Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add version support #817

Merged
merged 13 commits into from
Feb 1, 2024
Merged

Add version support #817

merged 13 commits into from
Feb 1, 2024

Conversation

Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
@cmichi
Copy link
Collaborator

cmichi commented Nov 9, 2023

@radhe-zeeve Is the PR intentionally in Draft? It seems ready to be merged to me?

@cmichi
Copy link
Collaborator

cmichi commented Nov 9, 2023

@radhe-zeeve CI is failing, but you should be able to see the log and fix it.

@radhe-zeeve
Copy link
Contributor Author

@cmichi This PR is intentionally in Draft, not complete.

- add routing with version number in backend

Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
- add ink compiler scripts

Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
@radhe-zeeve radhe-zeeve marked this pull request as ready for review December 13, 2023 18:35
Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
@radhe-zeeve radhe-zeeve force-pushed the version_play branch 5 times, most recently from f06fd5b to 88e7d0b Compare December 13, 2023 21:49
…onding dockerfile

Signed-off-by: Jasti Sri Radhe Shyam <[email protected]>
@radhe-zeeve
Copy link
Contributor Author

radhe-zeeve commented Dec 14, 2023

@cmichi PR is ready for review.

Couple of Github actions were modified to make the process faster and to mitigate the out of space issue. Following are the actions which were modified:

  • .github/workflows/docker.yml: Multiple images of ink were downloaded in ink playground container and this caused the storage to be full, so after the successful image build, while container creation the versions list is mounted with single version in the list which was used in one of test case.
  • .github/workflows/compiler_docker.yml: Only latest version image of ink compiler is been built, tagged and pushed to registry.

I have used my docker registry ID (radhezeeve) to push the images. and all the images part of this repository are public. The same registry ID is used in code base, which can be updated to older ID (achimcc) as soon as all the ink compiler images are updated on the older registry ID.

@cmichi cmichi merged commit c9c7c14 into use-ink:main Feb 1, 2024
1 check passed
@cmichi
Copy link
Collaborator

cmichi commented Feb 1, 2024

Thank you for working on this, @radhe-zeeve!

Unfortunately we have decided to archive this project, as we don't have the resources to operate it anymore. If you would be interested in doing so, please to the W3F. I know they also have maintenance grants, maybe that would be an option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants