-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve robustness of GitHub repo URL parsing #71
base: master
Are you sure you want to change the base?
Improve robustness of GitHub repo URL parsing #71
Conversation
For example this works now: https://github.com/MichaelAquilina/zsh-auto-notify/pull/67/files Previously `67` was taken as the repo owner and `files` as the repo name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It's a neat improvement.
A few things to change :)
After your changes, please provide a screenshot showing the results of different test-cases:
- empty input
bob
bob/bob
https://github.com/useful-forks/useful-forks.github.io/pull/71/files
useful-forks/useful-forks.github.io/pull/71/files
github.com/bob
github.com/payne911/PieMenu
payne911/PieMenu
@payne911 I don't have the time to take 8 screenshots but here are the results:
Performs a search for
The query field content is replaced with
Performs a search for If you have further comments and in order to avoid back-and-forths, I'd be grateful if you could address them directly. 🙏 Note that you have write access to this branch. |
For example this works now:
https://github.com/MichaelAquilina/zsh-auto-notify/pull/67/files
Previously
67
was taken as the repo owner andfiles
as the repo name.