replace production tpv api call with database query #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
reviewed
May 28, 2024
| from ( | ||
| select id, | ||
| CAST((REGEXP_MATCHES(encode(destination_params, 'escape'),'ntasks=(\d+)'))[1] as INTEGER) as cores, | ||
| CAST((REGEXP_MATCHES(encode(destination_params, 'escape'),'mem=(\d+)'))[1] as INTEGER) as mem, |
There was a problem hiding this comment.
We should be able to avoid the regex if we merge this: galaxyproject/tpv-shared-database#61
There was a problem hiding this comment.
eventually yes, there should be a more pleasant query, even one that can be expressed in sqlalchemy. For now, this works
cat-bro
changed the title
jlqfab
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the TPV's API call to the stats server with a database query. Destinations are still being ranked by the metric of %cpu used and future changes will consider memory as well. The result will be different because a job is counted in the query as soon as it has been queued, rather than as soon as it is running at the destination.
This is the first step in updating the ranking and we can observe whether it significantly increases the load on the database. Further changes will involve considering memory, and considering the quantity of resources available at various destinations instead of the proportion. I'd like to address the edge cases of low CPU high memory jobs that sometimes get stuck in the slurm queue when better destinations are immediately available.
Partly addresses issue #1142
This is ready to go but I've marked it as WIP - if merged I'd like to be around in case it throws exceptions.