Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FORCE] upgrade seq_filter_by_id #994

Merged
merged 2 commits into from
Dec 3, 2023
Merged

[FORCE] upgrade seq_filter_by_id #994

merged 2 commits into from
Dec 3, 2023

Conversation

neoformit
Copy link
Collaborator

Passes tests locally, but fails because of incorrect dir structure (can't find test-data).

@cat-bro
Copy link
Contributor

cat-bro commented Nov 30, 2023

@neoformit the yaml file needs to be within requests, not in the template folder. I fixed up the last one post merge

@neoformit
Copy link
Collaborator Author

Ahh of course... my bad. Thanks.

cat-bro
cat-bro approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@cat-bro cat-bro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be added to a trello for tools team to address the repository structure of this? Seems like something that could be fixed in peterjc's repo.

@cat-bro cat-bro merged commit 21e7aa3 into usegalaxy-au:master Dec 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-bro cat-bro cat-bro approved these changes

@jlqfab jlqfab Awaiting requested review from jlqfab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neoformit @cat-bro