Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #490

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Update README.md #490

merged 2 commits into from
Sep 4, 2020

Conversation

OlegZharkov
Copy link
Contributor

otherwise, it's really unclear how to build it (at least, it was for me)

otherwise, it's really unclear how to build it (at least, it was for me)
@simonbray
Copy link
Contributor

Are you sure this is correct? It doesn't work for me, I run it from the base directory without any problems.

I agree it would be good to improve the installation/build instructions - I have this note if this helps at all:

sudo apt install software-properties-common
sudo apt-add-repository -y ppa:rael-gc/rvm
sudo apt update
sudo apt install rvm # now check 'Run command as login shell' in terminal preferences and restart
rvm autolibs disable # so we don't have to give sudo our rvm pw
rvm requirements # manually install these, was nothing for me
rvm install ruby
gem install bundler
cd Repos/website/
bundle install --path vendor/bundle
bundle exec jekyll serve --watch

@simonbray
Copy link
Contributor

Oh I see there is a conda build system nowadays, nice.

@gmauro
Copy link
Member

gmauro commented Sep 4, 2020

I don't think you need to cd into _data
I just do in this way:

cd version/usegalaxy-eu/website/
conda create -n website
conda install ruby==2.4.1 #the same version used by Jenkins
gem update --system
gem install bundler
bundler install --gemfile _data/Gemfile
bundle exec --gemfile _data/Gemfile jekyll build

that is what our Jenkins server does (+/-).

@OlegZharkov
Copy link
Contributor Author

I don't think you need to cd into _data
I just do in this way:

cd version/usegalaxy-eu/website/
conda create -n website
conda install ruby==2.4.1 #the same version used by Jenkins
gem update --system
gem install bundler
bundler install --gemfile _data/Gemfile
bundle exec --gemfile _data/Gemfile jekyll build

that is what our Jenkins server does (+/-).

Yeah, because you're using --gemfile _data/Gemfile
otherwise, I get
Could not locate Gemfile

@bgruening
Copy link
Member

@OlegZharkov and all others, please checkout the Makefile. make install and make run

@bgruening
Copy link
Member

See: #442 :)

@OlegZharkov
Copy link
Contributor Author

make run

yeah. the best way, I guess

@OlegZharkov
Copy link
Contributor Author

Then I guess, wrong docs are worse than no docs.

@OlegZharkov
Copy link
Contributor Author

Are you sure this is correct? It doesn't work for me, I run it from the base directory without any problems.

I agree it would be good to improve the installation/build instructions - I have this note if this helps at all:

sudo apt install software-properties-common
sudo apt-add-repository -y ppa:rael-gc/rvm
sudo apt update
sudo apt install rvm # now check 'Run command as login shell' in terminal preferences and restart
rvm autolibs disable # so we don't have to give sudo our rvm pw
rvm requirements # manually install these, was nothing for me
rvm install ruby
gem install bundler
cd Repos/website/
bundle install --path vendor/bundle
bundle exec jekyll serve --watch

I tried to reproduce, doesn't work on Ubuntu 18.08

@bgruening
Copy link
Member

@OlegZharkov is the makefile thing working for you? If so you can add this....

@OlegZharkov
Copy link
Contributor Author

@OlegZharkov is the makefile thing working for you? If so you can add this....

make works, it's in docs. I just thougt, it might be a good idea to remove

bundle install --path vendor/bundle	
bundle exec jekyll serve --watch	

@beatrizserrano beatrizserrano merged commit 8c7216c into usegalaxy-eu:master Sep 4, 2020
@OlegZharkov
Copy link
Contributor Author

thank you @beatrizserrano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants