Fixes for passing DB Name #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust mariadb.Dockerfile
README: Added more information about what the different files do
builder/mariadb.Dockerfile: Made it get .my.cnf from a file, rather than having it embedded in the Dockerfile.
This is because we need two different my.cnf files at different points in the process.
builder/*my.cnf files: The my.cnf files we need at different points in the process
mariadb-image-builder:
* Renamed MTK_DUMP_* to MTK_* because the software is no longer called mtk-dump (and both were being used, which wasn't working)
* Added some more output for the logs
* Corrected mtk-dump command to work with new version of mtk (which was
changed in the last commit, but the script wasn't tested with the new
version)
|
Hi! Last time I put in some corrections, we didn't really have a way of testing them on our side (which I should've made clearer at the time). Now we do, and these are the corrections arising from the problems that we found. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile: Made it add everything from the builder/ directory, not just mariadb.Dockerfile
README: Added more information about what the different files do
builder/mariadb.Dockerfile: Made it get .my.cnf from a file, rather than having it embedded in the Dockerfile.
This is because we need two different my.cnf files at different points in the process.
builder/*my.cnf files: The my.cnf files we need at different points in the process
mariadb-image-builder: