Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Enable post-build scanning in insights-remote #677

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Jul 30, 2024

This PR supports the introduction of Post-build image scans in the insights-remote controller.

It supports the changes introduced in uselagoon/insights-remote#43

Further, we allow the insight remote scanning pods access to the dockerhost.

Essentially, the changes are around the cluster role to expand permissions (we now need to be able to CRUD pods), as well as allowing customization of the scanner image that's used in the scanning process.

  • The post-build image scanning is disabled by default, this is changed with insightsRemote.enableBuildScanning set to true
  • overriding the scan image can be done by explicitly setting insightsRemote.buildScannerImage to some image

@bomoko bomoko requested a review from tobybellwood November 6, 2024 00:09
@tobybellwood tobybellwood changed the base branch from main to lagoon_v222 November 11, 2024 05:34
@tobybellwood tobybellwood force-pushed the feature/insights_dockerhost_access branch from 8dafe4c to ea374ca Compare November 11, 2024 05:44
Base automatically changed from lagoon_v222 to main November 18, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants