Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds webhook notification to resolver type #2706

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Jun 17, 2021

Currently there's a table name resolution issue because of the way that knex converts names to snake_case, this was happening because the new webhook service wasn't part of the NotificationType resolver type.

This PR remedies this.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

@tobybellwood tobybellwood merged commit d971949 into uselagoon:main Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants