Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove all dangerous deleteAll and removeAll mutations #3753

Merged
merged 1 commit into from
Jul 4, 2024
Merged

chore: remove all dangerous deleteAll and removeAll mutations #3753

merged 1 commit into from
Jul 4, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jun 27, 2024 •
edited
Loading

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

This removes all the dangerous deleteAll and removeAll mutations from the API. These were only ever used during testing, and aren't used that often anymore in tests anyway.

Tearing down and recreating a Lagoon locally is much easier now than it used to be.

@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch from bc4abb5 to 8ac8955 Compare June 27, 2024 06:56
@shreddedbacon shreddedbacon added this to the 2.20.0 milestone Jun 27, 2024
@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch from 8ac8955 to ae55aa3 Compare June 27, 2024 23:28
@shreddedbacon shreddedbacon changed the title feat: add flag to enable dangerous mutations, disabled by default chore: remove all dangerous deleteAll and removeAll mutations Jun 27, 2024
@shreddedbacon shreddedbacon added the happy-to-delay pullrequest is fine to be left out of a release if required label Jun 27, 2024
@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch from ae55aa3 to 3738684 Compare June 27, 2024 23:32
@shreddedbacon shreddedbacon marked this pull request as ready for review July 2, 2024 04:47
@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch from 3738684 to bd16943 Compare July 3, 2024 04:22
@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch 3 times, most recently from 44bf1f4 to 0a1ba2c Compare July 4, 2024 03:19
@shreddedbacon shreddedbacon force-pushed the enable-dangerous-mutations-flag branch from 0a1ba2c to 7ca2988 Compare July 4, 2024 03:22
tobybellwood
tobybellwood approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, upgrades track ok too. LGTM

@tobybellwood tobybellwood merged commit f211a9d into main Jul 4, 2024
2 checks passed
@tobybellwood tobybellwood deleted the enable-dangerous-mutations-flag branch July 4, 2024 04:11
@shreddedbacon shreddedbacon mentioned this pull request Jul 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
happy-to-delay pullrequest is fine to be left out of a release if required
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood