Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove drutiny #3881

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Chore/remove drutiny #3881

merged 2 commits into from
Feb 16, 2025

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Feb 11, 2025

This PR supersedes #3197 by completely removing Drutiny webhook processing

closes #3082

@shreddedbacon
Copy link
Member

Do we need to announce the removal of this? Or is it unused code being removed?

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Just removal of unused functionality.

The question of whether this needs to be announced as a deprecation or just straight to removal can be done outside of this pullrequest if necessary though

@tobybellwood
Copy link
Member

Given zero effective usage and removal of other related functionality, this can just go without a warning.

@fubarhouse
Copy link
Contributor

giphy

@tobybellwood tobybellwood merged commit ab56723 into main Feb 16, 2025
1 check passed
@tobybellwood tobybellwood deleted the chore/remove_drutiny branch February 16, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights version 2 work - remove Lagoon Core Harbor/Trivy/Drutiny integration
4 participants