Skip to content

feat: prevent request stack in the constructor #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions Markup/Sniffs/Symfony/PreventRequestStackInConstructorSniff.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?php declare(strict_types=1);

namespace Markup\Sniffs\Symfony;

use SlevomatCodingStandard\Helpers\FunctionHelper;

class PreventRequestStackInConstructorSniff implements \PHP_CodeSniffer\Sniffs\Sniff
{
/**
* @return mixed[]
*/
public function register()
{
return [
T_FUNCTION,
];
}

/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
* @param \PHP_CodeSniffer\Files\File $phpcsFile
* @param int $openTagPointer
*/
public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $openTagPointer)
{
if (!FunctionHelper::isMethod($phpcsFile, $openTagPointer)) {
return;
}

$name = FunctionHelper::getName($phpcsFile, $openTagPointer);

if ($name !== '__construct') {
return;
}

foreach ($phpcsFile->getMethodParameters($openTagPointer) as $parameter) {
if (isset($parameter['type_hint']) && $parameter['type_hint'] === 'RequestStack') {
$phpcsFile->addError(
sprintf(
'Using RequestStack as a constructor argument ties the implementation to Reqest only which is not useful, see alteratives or context pass the Request from the HTTP Transport Layer',
$name
),
$openTagPointer,
'PreventRequestStackInConstructor'
);
}
}
}

}