Feature: multiple extensions for single language #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/terminal/ITerminalIDEServer.java
Outdated
Show resolved
Hide resolved
urbanfly
reviewed
Dec 12, 2023
urbanfly
reviewed
Dec 12, 2023
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/ParserOnlyContribution.java
Outdated
Show resolved
Hide resolved
jurgenvinju
approved these changes
Dec 12, 2023
|
Thanks. Well, I updated the pico example to use the new constructor. And the test fail, but that's just UI test jank, since only the first DSL test fails. In general there is not difference between how a language with 1 extension or more is handled now. |
|
Right. So if the tests work, then we are sure of that. But we should add a test for a language with two extensions right? Otherwise, this feature will break the next time someone does something "quickly". Like me :-) |
that seems wise, I added a test for it. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #343 we want to better align with LSP & VS Code by allowing multiple extensions for a single language.
The biggest change was in our multiplexer, which used to work by extension alone, but now maps extensions to language, and then continues as before.
I've tested that the old DSLs still work without requiring changes.