Fix token types to use LSP token types #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation was half working, due to an incorrect interpretation of the standard. This commit fixes that, but also adds modifiers Fixes #366
DavyLandman
force-pushed
the
feature/improve-syntax-highlighting-mapping
branch
from
36424ac to
515436d
Compare
DavyLandman
changed the title
DavyLandman
force-pushed
the
feature/improve-syntax-highlighting-mapping
branch
from
672e19a to
72d58d6
Compare
urbanfly
reviewed
Mar 20, 2024
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/SemanticTokenizer.java
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/SemanticTokenizer.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/SemanticTokenizer.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/util/SemanticTokenizer.java
Outdated
Show resolved
Hide resolved
DavyLandman
commented
Mar 20, 2024
urbanfly
reviewed
Mar 21, 2024
|
Will this PR make syntax highlighting Rascal code itself better/different? (like numbers in Rascal code will now be distinct?) |
Yes, they will now be highlighted (since before they were just the regular text color). But it requires some further tuning to get a difference between the string literals and the numeric literals. |
|
I want to merge this, but the windows runner is crashing on something weird. same case for main branch. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation was half working, due to an incorrect interpretation of the standard. This commits fixes that. For backwards compatibility: it still supports the legacy ones from rascal and also the wrong text-mate ones.
The rendering of Rascal is the same, except that string and numeric literals are now both highlighted as string (where before they were not highlighted). This is something we can only fix in the rascal grammar.
Also, side-effect, the list of tokens send to the client is less, as we only try and send those that have an
categoryand not all the plain ones.Fixes #366
TODO: