[USH-1539-ALT] Fix for collection editing rights #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angamanga
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Nice change @MMwandigha and good catch there @Ifycode. Teamwork 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the users with the role of 'Manage Collections and Saved Searches' permissions would only edit the collections that they created themselves, which is ideally not the way this works on the web platform
This pull request will now allow the users to edit any collection as long as they have the permission.
Here's the thread that prompted these changes to be made;
https://ushahidi.slack.com/archives/C07PW4NME5S/p1730365088343109?thread_ts=1730118226.988359&cid=C07PW4NME5S