Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra check for form_id and displaying messages in detailed view #1461

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Angamanga
Copy link
Contributor

Adding an extra check for form_id to not having to be dependent on post-fields to display the post.

To test:
Go to feed-view
Click on an unstructured post

  • The content should be visible in the post-detailed view
    Click on a structured post
  • The content should be visible in the post-detailed view

Copy link

linear bot commented Nov 15, 2024

@Angamanga Angamanga marked this pull request as ready for review November 15, 2024 12:00
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Angamanga Angamanga merged commit 866f65f into release/2024.45 Nov 15, 2024
10 of 12 checks passed
Angamanga added a commit that referenced this pull request Nov 15, 2024
…ew (#1461)

* Adding extra check for form_id and displaying messages in detailed view

* Checking for form_id instead of post_content

* Moving checks around
Angamanga added a commit that referenced this pull request Nov 15, 2024
…ew (#1461) (#1462)

* Adding extra check for form_id and displaying messages in detailed view

* Checking for form_id instead of post_content

* Moving checks around
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants