Skip to content

Commit

Permalink
Merge pull request #1554 from error404-sp/develop
Browse files Browse the repository at this point in the history
Added some attributes to improve accessibility
AmTryingMyBest authored Nov 27, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 290617c + f6697e8 commit b1937f2
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app/common/auth/login.html
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@

<div class="form-field">
<label for="email" translate>user.email</label>
<input type="text" id="email" ng-model="email" ng-disabled="processing" placeholder="[email protected]" required>
<input type="email" id="email" ng-model="email" ng-disabled="processing" placeholder="[email protected]" required>
</div>

<div class="form-field">
@@ -17,7 +17,7 @@
</div>
<div class="modal-actions">
<div class="form-field">
<button type="button" class="button-beta" ng-click="cancel()" ng-show="showCancel" translate="app.cancel">Cancel</button>
<button type="button" class="button-link" ng-click="cancel()" ng-show="showCancel" translate="app.cancel" aria-label="cancel">Cancel</button>
<button type="submit" class="button-alpha" ng-disabled="loginForm.$invalid || processing" translate="nav.login">Login</button>
</div>
</div>
2 changes: 1 addition & 1 deletion app/common/auth/password-reset-confirm.html
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
</div>
</div>
<div class="form-field">
<button type="button" class="button-link" ng-click="cancel()" translate="app.cancel">Cancel</button>
<button type="button" class="button-link" ng-click="cancel()" translate="app.cancel" aria-label="cancel">Cancel</button>
<button type="submit" class="button-primary"
ng-disabled="form.$invalid || processing">
<div class="loading" ng-show="processing"><div class="line"></div><div class="line"></div><div class="line"></div></div>
4 changes: 2 additions & 2 deletions app/common/auth/password-reset.html
Original file line number Diff line number Diff line change
@@ -7,13 +7,13 @@
translate>
user.email
</label>
<input type="text" id="email" name="email"
<input type="email" id="email" name="email"
ng-model="email"
ng-disabled="processing"
required>
</div>
<div class="form-field">
<button type="button" class="button-link" ng-click="cancel()" translate="app.cancel">Cancel</button>
<button type="button" class="button-link" ng-click="cancel()" translate="app.cancel" aria-label="cancel">Cancel</button>
<button type="submit" class="button-primary"
ng-disabled="form.$invalid || processing">
<div class="loading" ng-show="processing"><div class="line"></div><div class="line"></div><div class="line"></div></div>
2 changes: 1 addition & 1 deletion app/common/auth/register.html
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@

<div class="modal-actions">
<div class="form-field">
<button type="button" class="button-beta" ng-click="cancel()" translate="app.cancel">Cancel</button>
<button type="button" class="button-link" ng-click="cancel()" translate="app.cancel" aria-label="cancel">Cancel</button>
<button type="submit" class="button-alpha" ng-disabled="form.$invalid || processing" translate="nav.register">Sign up</button>
</div>
</div>

0 comments on commit b1937f2

Please sign in to comment.