Skip to content

Commit

Permalink
USH-684: add HttpSMS data-provider entry , other clean-up
Browse files Browse the repository at this point in the history
  • Loading branch information
tuxpiper committed Mar 30, 2024
1 parent 85a7a5f commit 1ed134a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions config/data-provider.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
'gmail' => false,
'mteja' => false,
'africastalking' => false,
'httpsms' => false,

This comment has been minimized.

Copy link
@tuxpiper

tuxpiper Mar 30, 2024

Author Member

Without this line, deployments won't look for these new data providers. With this missing in the code, a similar entry needs to be added to the config table JSON (group_name="data-provider", config_key="providers"). It seems like this db update was manually done in staging environments, and I bet local too, then forgotten in regards of the implications for other deployments. Let's not forget again.

],

'authenticable-providers' => [
Expand Down
2 changes: 1 addition & 1 deletion src/Ushahidi/Addons/HttpSMS/HttpSMS.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Ushahidi\Addons\HttpSMS;

/**
* Infobip Data Source
* HttpSMS Data Source
*
* @author Ushahidi Team <[email protected]>
* @package Addons\HttpSMS
Expand Down
2 changes: 1 addition & 1 deletion src/Ushahidi/Addons/Infobip/InfobipServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public function send($to, $message, $title = "", $contact_type = null, $message_
if ($content['status'] == 'success') {
return [MessageStatus::SENT, $content['data']['id']];
} else {
Log::error('HttpSMS: Failed to send message: ' . $content['message']);
Log::error('Infobip: Failed to send message: ' . $content['message']);
return [MessageStatus::FAILED, false];
}
}
Expand Down

0 comments on commit 1ed134a

Please sign in to comment.