Fix some access levels in MainSolver and add some checks to public …
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making |
Tomaqa
force-pushed
the
688-fix-mainsolver-api
branch
from
dc42738
to
d001afa
Compare
blishko
reviewed
Mar 25, 2024
test/unit/test_UFInterpolation.cc
Outdated
| @@ -11,6 +11,12 @@ bool verifyInterpolant(PTRef itp, PartitionManager & pManager, ipartitions_t con | |||
| return VerificationUtils(logic).verifyInterpolantInternal(pManager.getPartition(Amask, PartitionManager::part::A), pManager.getPartition(Amask, PartitionManager::part::B), itp); | |||
| } | |||
|
|
|||
| struct TestMainSolver : MainSolver { | |||
There was a problem hiding this comment.
I don't particularly like the approach of creating subclasses solely for the purpose being able to access some protected member.
I think a better solution here would be to do what LRAInterpolationTest is doing, i.e., explicitly track the partitions in each test.
That way the public API is sufficient.
added 2 commits
March 26, 2024 14:55
Tomaqa
force-pushed
the
688-fix-mainsolver-api
branch
from
1d2cdc3
to
eb7ef02
Compare
|
Please, next time, make sure that the title of git commit is limited to 72 characters, so that GitHub does not split it when creating a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…member functions.
Related to #688 (does not fully resolve)