Skip to content

Commit

Permalink
inherit secrets and workflow_dispatch (bcgov#1267)
Browse files Browse the repository at this point in the history
* inherit secrets and workflow_dispatch

require manual action running and inherit the secrets

* clean up

separated the steps of the workflow into separate jobs

* reverting back to old pr workflow

we are reverting back to the old pr workflow until we can find an alternative that works and is secure

* reverted more

reverted the job to steps for on_push and undid changes to unit-tests

* Update on_push.yaml

removed inherit secrets
  • Loading branch information
jasonchung1871 authored Feb 6, 2024
1 parent 731ffc1 commit 89fa641
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 80 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/on_pr_opened.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ concurrency:
jobs:
build:
name: Build & Push
if: "github.event.pull_request.author_association != 'COLLABORATOR' && github.event.review.author_association != 'OWNER'"
environment:
name: pr-external
url: https://${{ env.ACRONYM }}-dev.apps.silver.devops.gov.bc.ca/pr-${{ github.event.number }}
if: "! github.event.pull_request.head.repo.fork"
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
Expand All @@ -37,12 +34,12 @@ jobs:
github_token: ${{ secrets.GITHUB_TOKEN }}
app_title: Common Hosted Forms - PR-${{ github.event.number }}
route_path: /pr-${{ github.event.number }}
app_contact: ${{ secrets.VITE_CONTACT }}
app_contact: ${{ vars.CHEFS_CONTACT }}

deploy-pr-dev:
name: Deploy Pull Request to Dev
environment:
name: pr-external
name: pr
url: https://${{ env.ACRONYM }}-dev.apps.silver.devops.gov.bc.ca/pr-${{ github.event.number }}
runs-on: ubuntu-latest
needs: build
Expand Down Expand Up @@ -70,4 +67,4 @@ jobs:
with:
header: release
message: |
Release ${{ github.sha }} deployed at <https://${{ env.ACRONYM }}-dev.apps.silver.devops.gov.bc.ca/pr-${{ github.event.number }}>
Release ${{ github.sha }} deployed at <https://${{ env.ACRONYM }}-dev.apps.silver.devops.gov.bc.ca/pr-${{ github.event.number }}>
73 changes: 0 additions & 73 deletions .github/workflows/on_pr_opened_collaborator.yaml

This file was deleted.

0 comments on commit 89fa641

Please sign in to comment.