-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor jobs restapi to split up id and name functionality #355
Conversation
Going to begin my review, to start I'm going to rebase on dev and force-push to ensure all the tests are still passing. |
beea158
to
71d7055
Compare
The status check is unnecessary since it was already validated by Marshmallow schema. In addition, the database will not complete the transaction if the status value is invalid.
In addition, also remove redudant code that was doing error validation checks that would have already been validated elsewhere.
Pushing some updates to this branch. Most of them are minor stylistic things that weren't worth doing a code change request for (see end of comment for a list). The non-stylistic stuff I found in my review was the following, along with how I addressed them.
The minor stylistic stuff:
If all the tests pass, then I think this will be good for a merge. |
Refactors the job endpoint to split up functionality of name and id requests. Includes minor changes to the unit tests to reflect those changes. Resolves #313
Changes