Refactor task plugins #356
Conversation
| raise TaskPluginDoesNotExistError | ||
|
|
||
| return task_plugin | ||
| return cast(TaskPlugin, task_plugin) |
There was a problem hiding this comment.
Not sure if this is needed, service functions already returns TaskPlugin type.
There was a problem hiding this comment.
I believe this was due to mypy complaining, but if removing the cast still passes all the tests I'm happy to fix it!
|
365 Reviewed: File changes look clean. All tests passing on local deployment. |
|
I've begun my review of this. I also rebased on the latest version of Will continue working through this later. |
jkglasbrenner
force-pushed
the
abyrne-refactor-task-plugins
branch
from
c9dfe6c to
d851263
Compare
Remove the dependency on WTForms from the taskPlugin endpoint. Closes #319 Co-authored-by: James K. Glasbrenner <[email protected]>
jkglasbrenner
force-pushed
the
abyrne-refactor-task-plugins
branch
from
d851263 to
2168309
Compare
There was a problem hiding this comment.
I've wrapped up with this. The only other change I did was split TaskPluginService into two classes, TaskPluginService and TaskPluginCollectionService so that we only have get() and get_all() methods. I updated the one unit test affected by this change. Otherwise, it's passing all tests and looks good, so I'm going to merge to dev.
Refactor the task plugins endpoint to reflect changes to queue and remove wtforms dependency. Resolves #319
Changes