Replace Empty String with Null for Version Handling in Dataset Caching #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayPlante
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Please look at RPACachingService, line 82, which raises a NullPointerException when version is null. Please review the rest of this implementation to make sure it can handle a null version.
RayPlante
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the logic for handling dataset version in the
rpaCachingService.cacheAndGenerateRandomId()method. Previously, an empty string ("") was passed when no version was available, which caused an error in the downstream logic. To ensure that the latest version is selected when no version is provided,nullis now passed instead of an empty string.Changes:
""withnullinrpaCachingService.cacheAndGenerateRandomId()Testing: