Fix/fields

[chuanlin2018]

Hi Mehdi, I think I fixed the multiple requests issue. Please verify.
You can either merge it into integration or your fix/unnecessary-core-js branch if you confirm it's fixed.
Thanks.
Chuan

[shiftmed]

Hello Chuan,

On the home page, the issue seems to be fixed. Each refresh of the app correctly requests the fields endpoint a single time.

On the search page, it appears to be trickier. On the first search (i.e. home page => type into search box => launch search), it triggers an additional /fields request (which I suppose is working as intended); however if I now refresh that same page with the results already loaded (i.e. "launch" the app from the URL), 3 requests to the fields endpoint are triggered as displayed on the screenshot below.

[chuanlin2018]

I’ll take a look. From: shiftmed ***@***.***> Date: Tuesday, December 17, 2024 at 6:43 PM To: usnistgov/oar-sdp ***@***.***> Cc: Lin, Chuan (Assoc) ***@***.***>, Author ***@***.***> Subject: Re: [usnistgov/oar-sdp] Fix/fields (PR #326) Hello Chuan, On the home page, the issue seems to be fixed. Each refresh of the app correctly requests the fields endpoint a single time. On the search page, it appears to be trickier. On the first search (i.e. home page => type into search box => launch search), it triggers an additional /fields request (which I suppose is working as intended); however if I now refresh that same page with the results already loaded (i.e. "launch" the app from the URL), 3 requests to the fields endpoint are triggered as displayed on the screenshot below. fields-bug.png (view on web)<https://github.com/user-attachments/assets/8a38f4eb-0a22-49ce-92ae-5f3f3d97e177> — Reply to this email directly, view it on GitHub<#326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKQHD3DZNQEMNT6HADGBAYT2GCZKNAVCNFSM6AAAAABTZDSGPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBZHEYTAMJVGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[chuanlin2018]

I think it's fixed this time...

[shiftmed]

The fields endpoint now successfully only gets queried once.

There is however a new unexpected behavior during filtering:

• Filtering does not display the "check mark" anymore when selecting a filter,
• Clicking on a filter a second time does not "toggle off" the filter

To replicate:

• Search for "star",
• Click on "Research Topics" in the filters section

Thanks @chuanlin2018!

[chuanlin2018]

Ah! I will take a look...

[chuanlin2018]

Worked for me... I was able to check and uncheck any box.

[shiftmed]

Thanks @chuanlin2018. I am investigating this; it seems to be a bug on my end related to a mismatch between Angular 18 and PrimeNG.

This PR is passing.