-
Notifications
You must be signed in to change notification settings - Fork 188
A ton of addedd stuff #78
base: master
Are you sure you want to change the base?
Conversation
…y patches on gunicorn and vobject
… settings.py config
…deleting users,services,schedules; add pseudo-ACLs(only staff and user himself can modify/test notification on a user; only staff can delete/create new users)
…transfer) an incident to another service so that it's on-call,fallback etc. be notified as well
…; add pseudo-management of users in groups with checkboxes on user edit page(django admin still needed to create groups)
…est 500 incidents
@@ -0,0 +1,7 @@ | |||
[Service] | |||
Environment="User=www-data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just set the User= option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, all of these should likely be set as actual systemd options, not as environment variables:
Group=
PidFile=
WorkingDirectory
Setting these in environment variables, and then spawning a shell so that you can consume them as environment variables actually leads to less configurability in the long run.
A lot of this could be solved by setting Type=forking
to let systemd know to just use it's default behavior for a forking process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I'll take this PR and try to work on improving some of the systemd-isms this week.
Thanks! Any other remarks? Frankly, this was the first time i've dabbled with systemd, which leads to suboptimal configuration, apparently. Waiting for your PR :) Cheers, |
Thank you for your contribution, we will test it this week and write back. Thanks! |
Hi all, Thanks for the pull request, I'm trying to add a trigger with the django rest form. HTTP 403 Forbidden [ The service key is a form selector. It's not empty Thanks for your help It's possible to add so documentation about the api usage? |
Any updates on when this can be merged? |
@sofixa so as ustream isn't maintaining the project anymore: Maybe your team at @Oxalide could continue maintaining the fork? |
Hello, everybody. As i promised some time ago, i'm creating a PR with all of the modifications that we at Oxalide have done.
Non-exhaustive list of things added:
Backend
Notifiers
Frontend
Env
I'm inviting everyone ( ping @deathowl , @krutaw , @luto ) to review, comment, commit, etc. :)
TODO (starting next week, contributions welcome!)
Cheers !
Adrian