Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme changing works now #17

Merged
merged 6 commits into from
Apr 11, 2023
Merged

theme changing works now #17

merged 6 commits into from
Apr 11, 2023

Conversation

logonoff
Copy link
Member

No description provided.

@logonoff logonoff requested a review from daniyalb April 10, 2023 18:17
daniyalb
daniyalb requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@daniyalb daniyalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, there's just an issue where if you're in dark mode, the site is in light mode for a fraction of a second when ever you switch between pages, causing the webpage to kind of flash

@daniyalb daniyalb added the enhancement New feature or request label Apr 10, 2023
@logonoff
Copy link
Member Author

logonoff commented Apr 11, 2023 •
edited
Loading

It looks good overall, there's just an issue where if you're in dark mode, the site is in light mode for a fraction of a second when ever you switch between pages, causing the webpage to kind of flash

unfortunately an issue with MUI: https://github.com/mui/material-ui/issues/27651

although the avoidance of react router links isn't helping, the initial flash upon page load is beyond our control

@logonoff logonoff merged commit cbb4117 into main Apr 11, 2023
@logonoff logonoff deleted the darkmode branch April 12, 2023 02:13
@logonoff logonoff linked an issue Apr 12, 2023 that may be closed by this pull request
Settings don't appear to work at all: dark mode #24
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniyalb daniyalb daniyalb requested changes

Assignees

@logonoff logonoff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings don't appear to work at all: dark mode
2 participants
@logonoff @daniyalb