Internal ids chunks

src/Database/Adapter/MariaDB.php

@@ -981,7 +981,7 @@ public function createDocuments(string $collection, array $documents, int $batch
         try {
             $name = $this->filter($collection);
             $batches = \array_chunk($documents, \max(1, $batchSize));
-            $documentIds = \array_map(fn ($document) => $document->getId(), $documents);
+            $documentIds = [];
 
             foreach ($batches as $batch) {
                 $bindIndex = 0;
@@ -990,15 +990,19 @@ public function createDocuments(string $collection, array $documents, int $batch
                 $permissions = [];
 
                 foreach ($batch as $document) {
+                    /**
+                     * @var Document $document
+                     */
                     $attributes = $document->getAttributes();
                     $attributes['_uid'] = $document->getId();
                     $attributes['_createdAt'] = $document->getCreatedAt();
                     $attributes['_updatedAt'] = $document->getUpdatedAt();
                     $attributes['_permissions'] = \json_encode($document->getPermissions());
 
                     if (!empty($document->getInternalId())) {
-                        $internalIds[$document->getId()] = true;
                         $attributes['_id'] = $document->getInternalId();
+                    } else {
+                        $documentIds[] = $document->getId();
                     }
 
                     if ($this->sharedTables) {
@@ -1077,27 +1081,35 @@ public function createDocuments(string $collection, array $documents, int $batch
                 }
             }
 
-            // Get internal IDs
-            $sql = "
+            $internalIds = [];
+
+            /**
+             * UID, _tenant bottleneck is ~ 5000 rows since we use _uid IN query
+             */
+            foreach (\array_chunk($documentIds, 3000) as $documentIdsChunk) {
+                // Get internal IDs
+                $sql = "
                 SELECT _uid, _id
                 FROM {$this->getSQLTable($collection)}
-                WHERE _uid IN (" . implode(',', array_map(fn ($index) => ":_key_{$index}", array_keys($documentIds))) . ")
+                WHERE _uid IN (" . implode(',', array_map(fn ($index) => ":_key_{$index}", array_keys($documentIdsChunk))) . ")
                 {$this->getTenantQuery($collection)}
             ";
+                $stmt = $this->getPDO()->prepare($sql);
 
-            $stmt = $this->getPDO()->prepare($sql);
+                foreach ($documentIdsChunk as $index => $id) {
+                    $stmt->bindValue(":_key_{$index}", $id);
+                }
 
-            foreach ($documentIds as $index => $id) {
-                $stmt->bindValue(":_key_{$index}", $id);
-            }
+                if ($this->sharedTables) {
+                    $stmt->bindValue(':_tenant', $this->tenant);
+                }
 
-            if ($this->sharedTables) {
-                $stmt->bindValue(':_tenant', $this->tenant);
-            }
+                $stmt->execute();
+                $results = $stmt->fetchAll(PDO::FETCH_KEY_PAIR); // Fetch as [documentId => internalId]
+                $stmt->closeCursor();
 
-            $stmt->execute();
-            $internalIds = $stmt->fetchAll(PDO::FETCH_KEY_PAIR); // Fetch as [documentId => internalId]
-            $stmt->closeCursor();
+                $internalIds = array_merge($internalIds, $results);
+            }
 
             foreach ($documents as $document) {
                 if (isset($internalIds[$document->getId()])) {

src/Database/Database.php

@@ -141,8 +141,8 @@ class Database
     public const EVENT_INDEX_CREATE = 'index_create';
     public const EVENT_INDEX_DELETE = 'index_delete';
 
-    public const INSERT_BATCH_SIZE = 10_000;
-    public const DELETE_BATCH_SIZE = 10_000;
+    public const INSERT_BATCH_SIZE = 3_000;
+    public const DELETE_BATCH_SIZE = 3_000;
 
     /**
      * List of Internal attributes
@@ -3418,6 +3418,16 @@ public function createDocuments(
 
         $collection = $this->silent(fn () => $this->getCollection($collection));
 
+        /**
+         * Check collection exist
+         */
+        if ($collection->getId() !== self::METADATA) {
+            $authorization = new Authorization(self::PERMISSION_CREATE);
+            if (!$authorization->isValid($collection->getCreate())) {
+                throw new AuthorizationException($authorization->getDescription());
+            }
+        }
+
         $time = DateTime::now();
 
         foreach ($documents as $key => $document) {