-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SmsGlobal messaging adapter #40
base: main
Are you sure you want to change the base?
Added SmsGlobal messaging adapter #40
Conversation
tests/e2e/SMS/SmsGlobalTest.php
Outdated
$this->assertArrayHasKey('messages', $result); | ||
$this->assertEquals(count($to), count($result['messages'])); | ||
|
||
// $dummyResponseStructure = '{"messages":[{"id":"154","outgoing_id":1,"origin":"origin","destination":"destination","message":"Test Content","status":"sent","dateTime":""}]}'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this comment if it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gewenyu99, removed the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please make sure to address the linting problems?
Hi @stnguyen90, resolved the linting problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
Hi @gewenyu99, My discord username is |
Will reach out soon! Compiling everyone's user names. Appreciate your patience! |
What does this PR do?
This Pull Request (PR) adds an SmsGlobal messaging adapter along with tests.
Test Plan
Create Your SmsGlobal Account
Obtain API Key and API Secret
Enable Sandbox (For Testing)
Set Environment Variables and Run E2E Tests
Before running end-to-end (E2E) tests, make sure you have the following environment variables set:
SMS_GLOBAL_API_KEY
SMS_GLOBAL_API_SECRET
SMS_GLOBAL_TO
SMS_GLOBAL_FROM
Execute the following command to run the E2E tests:
Screenshots
From SmsGlobal dashboard
Related PRs and Issues
Closes appwrite/appwrite#6403
Have you read the Contributing Guidelines on issues?
Yes