Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added CM SMS Adapter #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VividhPandey003
Copy link

What does this PR do?

Implement support for CM in the Utopia PHP messaging library.

Test Plan

Related PRs and Issues

solves Issue

Have you read the Contributing Guidelines on issues?

Yes

Signed-off-by: Vividh Pandey <[email protected]>
@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

1 similar comment
@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

@wess
Copy link
Contributor

wess commented Nov 15, 2023

The linter is failing, i realize that the other test will fail for credentials, but please run the linter's formatter on it

@VividhPandey003 VividhPandey003 changed the title Feat: Added CM SMS Adapter feat: Added CM SMS Adapter Nov 15, 2023
Signed-off-by: Vividh Pandey <[email protected]>
@VividhPandey003
Copy link
Author

The linter is failing, i realize that the other test will fail for credentials, but please run the linter's formatter on it

Hey, sorry for the Linting issue, I have fixed it. Could you please review it again @wess

@VividhPandey003
Copy link
Author

Discord username- vividh003#7271

@gewenyu99
Copy link

Sent a friend request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants