Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Filter invalid btc block for btc time cells unlock #200

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

duanyytop
Copy link
Collaborator

@duanyytop duanyytop commented Jul 24, 2024

Changes

  • If the block height of the BTC txid is less than the BTC SPV start height when unlocking a BTC time cell, skip it

Copy link

vercel bot commented Jul 24, 2024

@duanyytop is attempting to deploy a commit to the Cell Studio Team on Vercel.

To accomplish this, @duanyytop needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@duanyytop duanyytop requested review from Flouse and ahonn and removed request for Flouse July 24, 2024 03:12
@duanyytop duanyytop force-pushed the ref/filter-invalid-block branch from cc32f43 to 4206d7e Compare July 24, 2024 03:14

// estimate time: 2024-04-02 06:20:03
// ref: https://mempool.space/block/0000000000000000000077d98a103858c7d7cbc5ba67a4135f348a436bec1748
export const BTC_MAINNET_SPV_START_BLOCK_HEIGHT = 837300;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the starting block height for Signet be included?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 2f59061

@Flouse Flouse merged commit 75663cf into develop Jul 24, 2024
2 of 3 checks passed
@Flouse Flouse deleted the ref/filter-invalid-block branch July 24, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants