Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to main branch (v2.5.7) #232

Merged
merged 31 commits into from
Jan 17, 2025
Merged

Merge develop to main branch (v2.5.7) #232

merged 31 commits into from
Jan 17, 2025

Conversation

ahonn
Copy link
Collaborator

@ahonn ahonn commented Jan 17, 2025

What's Changed

New Env

Only available when BITCOIN_DATA_PROVIDER = mempool

 /**
   * The IBitcoinClient methods to use Electrs as default data provider
   * use electrs as default, mempool.space as fallback
   */
  BITCOIN_METHODS_USE_ELECTRS_BY_DEFAULT: z
    .string()
    .default('')
    .transform((value) => value.split(','))
    .pipe(z.string().array()),

duanyytop and others added 29 commits January 6, 2025 13:13
Upgrade rgbpp-sdk to support compatible udt
Decode unique cell token info and metadata
Support UTXO Airdrop Badge type script
Add compatible xUDT info whitelist
…n-incorrectdifferent-valueorder

feat(bitcoin): add configurable default data provider per method when use mempool
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
btc-assets-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:17am

Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error when testing PR #231 on a testnet instance:

assets-service          | [09:02:48 UTC] WARN: Fallback to MempoolClient due to error: Cannot read properties of undefined (reading 'get')
assets-service          | [09:02:48 UTC] ERROR: Cannot read properties of undefined (reading 'bitcoin')
assets-service          |     err: {
assets-service          |       "type": "TypeError",
assets-service          |       "message": "Cannot read properties of undefined (reading 'bitcoin')",
assets-service          |       "stack":
assets-service          |           TypeError: Cannot read properties of undefined (reading 'bitcoin')
assets-service          |               at ElectrsClient.getAddressTxs (/app/dist/src/services/bitcoin/mempool.js:130:45)
assets-service          |               at [BitcoinClient.call](https://bitcoinclient.call/) (/app/dist/src/services/bitcoin/index.js:137:70)
assets-service          |               at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
assets-service          |     }

@Flouse Flouse requested a review from mfuuzy January 17, 2025 09:17
@Flouse Flouse merged commit 8327f3c into main Jan 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants