-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop to main branch (v2.5.7) #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade rgbpp-sdk to support compatible udt
Remove redundent xUDT checking
Decode unique cell token info and metadata
Support UTXO Airdrop Badge type script
Update token info to snake case
Add compatible xUDT info whitelist
…n-incorrectdifferent-valueorder feat(bitcoin): add configurable default data provider per method when use mempool
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShookLyngs
approved these changes
Jan 17, 2025
duanyytop
approved these changes
Jan 17, 2025
Flouse
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error when testing PR #231 on a testnet instance:
assets-service | [09:02:48 UTC] WARN: Fallback to MempoolClient due to error: Cannot read properties of undefined (reading 'get')
assets-service | [09:02:48 UTC] ERROR: Cannot read properties of undefined (reading 'bitcoin')
assets-service | err: {
assets-service | "type": "TypeError",
assets-service | "message": "Cannot read properties of undefined (reading 'bitcoin')",
assets-service | "stack":
assets-service | TypeError: Cannot read properties of undefined (reading 'bitcoin')
assets-service | at ElectrsClient.getAddressTxs (/app/dist/src/services/bitcoin/mempool.js:130:45)
assets-service | at [BitcoinClient.call](https://bitcoinclient.call/) (/app/dist/src/services/bitcoin/index.js:137:70)
assets-service | at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
assets-service | }
fix: fix method context binding
mfuuzy
approved these changes
Jan 17, 2025
Flouse
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
To resolve the issue (mempool.space API returns an incorrect/different value/order #221), a new env var
BITCOIN_METHODS_USE_ELECTRS_BY_DEFAULT
is required:New Env
Only available when
BITCOIN_DATA_PROVIDER = mempool