perf: cache the SPV instance to improve the performance of the JSON-RPC APIs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
refactor/cache-spv-cells
branch
from
03f3e27 to
309b2c1
Compare
EthanYuan
reviewed
Apr 18, 2024
EthanYuan
reviewed
Apr 20, 2024
|
|
||
| log::debug!(">>> try the cached SPV instance at first"); | ||
|
|
||
| let spv_instance = if let Some(spv_instance) = self.load_spv_instance() { |
There was a problem hiding this comment.
if spv_best_height(from cache) < target_height + confirmations, the service rpc get_tx_proof will keep returning errors until the cache expires.
In other words, if the current cache doesn't hit, the api doesn't go through ckb_cli to get the latest spv client instance, but just waits for the cache to expire.
This was referenced May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.