chore: more documentations and remove duplicated code #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
changed the title
jjyr
approved these changes
Apr 19, 2024
EthanYuan
approved these changes
Apr 20, 2024
EthanYuan
reviewed
Apr 20, 2024
| /// | ||
| /// ### Warnings | ||
| /// | ||
| /// The owner should be an address which uses a ACP-like script. |
There was a problem hiding this comment.
Suggested addition:
"Otherwise unintended results may occur. If the unlocking of the current spv instance requires a signature, update and reorg operations may produce irreversible failures when this SpvOwner fills in another address that requires a signature to unlock."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more help docs.
Remove duplicated code.
There are two exactly same functions:
check_inputsandcheck_remotes.