Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): support /rgbpp/v1/address/{btc_address}/activity #250

Merged
merged 3 commits into from
Aug 28, 2024
Merged

feat(service): support /rgbpp/v1/address/{btc_address}/activity #250

merged 3 commits into from
Aug 28, 2024

Conversation

ShookLyngs
Copy link
Collaborator

@ShookLyngs ShookLyngs commented Jul 11, 2024 •
edited by Flouse
Loading

Changes

  • Add support of the /rgbpp/v1/address/{btc_address}/activity API for querying RGBPP asset activities by an BTC address, adapting changes in btc-assets-api#182 and btc-assets-api#194
  • Fix the type of BtcApiBlockchainInfo.bestblockhash to string
  • Update types in the service lib README

Known Issue

@ShookLyngs ShookLyngs force-pushed the feat/assets-api-182 branch from abad2e6 to 599fd8a Compare July 11, 2024 06:15
Flouse
Flouse previously approved these changes Jul 11, 2024
View reviewed changes
@Flouse Flouse enabled auto-merge July 11, 2024 07:48
@Flouse Flouse requested a review from duanyytop July 16, 2024 08:14
@Flouse Flouse mentioned this pull request Jul 18, 2024
Merged
@Flouse Flouse marked this pull request as draft July 19, 2024 06:26
auto-merge was automatically disabled July 19, 2024 06:26

Pull request was converted to draft

@Flouse Flouse changed the title feat(service): adapt btc-assets-api#182 feat(service): Add support of the /rgbpp/v1/address/{btc_address}/activity Jul 23, 2024
@Flouse Flouse changed the title feat(service): Add support of the /rgbpp/v1/address/{btc_address}/activity feat(service): support /rgbpp/v1/address/{btc_address}/activity Jul 23, 2024
@ShookLyngs ShookLyngs force-pushed the feat/assets-api-182 branch from 599fd8a to aecd837 Compare August 23, 2024 19:28
@ShookLyngs ShookLyngs marked this pull request as ready for review August 23, 2024 19:35
@ShookLyngs ShookLyngs requested review from duanyytop and Flouse August 23, 2024 19:35
@Flouse Flouse merged commit 3ee71df into develop Aug 28, 2024
3 checks passed
@Flouse Flouse deleted the feat/assets-api-182 branch August 28, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dawn-githup Dawn-githup Dawn-githup approved these changes

@duanyytop duanyytop duanyytop approved these changes

@Flouse Flouse Flouse approved these changes

@ahonn ahonn Awaiting requested review from ahonn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShookLyngs @Flouse @duanyytop @Dawn-githup