-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
tsort: fix minimal cycle reporting and precise back-edge removal (no refactors) #8786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GNU testsuite comparison:
|
…oval - Report only minimal cycle subpath when loop is detected - Remove exact closing back-edge (last -> first) for deterministic progress - Maintain existing DFS structure without architectural changes - Address issue with incorrect loop detection
7a4ae04
to
e590069
Compare
GNU testsuite comparison:
|
CodSpeed Performance ReportMerging #8786 will improve performances by 89.99%Comparing Summary
Benchmarks breakdown
Footnotes
|
Clean up cycle detection code by removing redundant comments that don't add meaningful value to the implementation.
GNU testsuite comparison:
|
GNU testsuite comparison:
|
This PR fixes incorrect loop reporting in tsort by reporting only the minimal cycle subpath and removing the precise back-edge that closes the cycle. No performance refactors or unrelated changes are included.
Context
What changed
Why
Non-goals of this PR
Testing
cargo test --package uu_tsort
and the top-levelcargo test tests
locally; both succeededFollow-up PRs in planned split
This focused PR should be easier to review and merge, addressing the core correctness issue independently.