Skip to content

Conversation

oech3
Copy link
Contributor

@oech3 oech3 commented Oct 4, 2025

Allow to replace ln-fs by make LN=ln (Minimized replacement for #8790 and #7928 ).

Reasons:

  1. Windows does not allow symlinking by default. It blocks to build this as single binary at MSYS2.
  2. AppArmor needs proper argv[0] .

I have no idea what test should we have for this feature.

Copy link

github-actions bot commented Oct 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Copy link

codspeed-hq bot commented Oct 4, 2025

CodSpeed Performance Report

Merging #8810 will not alter performance

Comparing oech3:ln (6cdf6aa) with main (be25344)

Summary

✅ 69 untouched
⏩ 73 skipped1

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Contributor

Please add a github action test. That will do

Add test for make LN="ln -svf" and make LN="ln -vf"
@oech3
Copy link
Contributor Author

oech3 commented Oct 4, 2025

Added tests for LN=

Copy link

github-actions bot commented Oct 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants