Incorporate NOAA and NCALM to search #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed merge conflict between remote branches local vs cryocloud on updated main.py search
…nd accept arguments from _validate_temporal_bounds
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
scottyhq
reviewed
Dec 18, 2024
scottyhq
reviewed
Dec 18, 2024
scottyhq
reviewed
Dec 18, 2024
scottyhq
reviewed
Dec 18, 2024
scottyhq
reviewed
Dec 18, 2024
scottyhq
reviewed
Dec 18, 2024
scottyhq
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Thanks for this great addition @Jack-Hayes, really appreciate the added docs too! Just pushed a couple commits to make the tests and linter happy. We can revisit some of the TODO comments later, as this is already a good amount of content for one PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the NOAA Coastal LiDAR and NCALM datasets to the search via the OpenTopo API. This is messy and dependent on a fixed structure of the catalogs' responses. Using the requests library to do so.