Framework for reprojection to ellipsoid heights #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
scottyhq
commented
Feb 2, 2025
| @@ -109,3 +207,713 @@ def plot_maxar_browse(item: pystac.Item, overview_level: int = 0) -> plt.Axes: | |||
| da.plot.imshow(rgb="band", add_labels=False, ax=ax) | |||
| ax.set_aspect(aspect=1 / np.cos(np.deg2rad(mid_lat))) | |||
| ax.set_title(item.id) | |||
|
|
|||
|
|
|||
| # NOTE: xdem.DEM.hillshade method expects the same x and y resolution | |||
There was a problem hiding this comment.
This gets back to scoping. Should xdem just be a dependency (coincident as 'kitchen sink' package), or instead just focus on search and data organization to hand off to these other libraries?... In any case, for now I think this basic visual hillshade is convenient to have for plots! The GDAL hillshade implementation is also a bit more sophisticated with handling different x/y/z scales: https://gdal.org/en/stable/drivers/raster/vrt.html#vrt-that-computes-hillshading-using-an-external-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.rst