BICBridgeGRPCService Testing Methods Development #33
Conversation
| // Finally assemble the server. | ||
| gRPCServer = builder.BuildAndStart(); | ||
| std::cout << "Server listening on " << server_address << std::endl; | ||
|
|
There was a problem hiding this comment.
let's remove extra whitespace
|
|
||
| // Check that when no bridges are connected, listBridges can be called without any error | ||
| EXPECT_EQ(val.ok(), true); | ||
|
|
There was a problem hiding this comment.
We should check that no bridges were returned?
There was a problem hiding this comment.
need to check both that the grpc call succeed (which is what you're doing (val.ok is true) but also that the reply is what you expect.
|
|
||
| // Per-test teardown | ||
| // Called after each test | ||
| void TearDown() override { |
There was a problem hiding this comment.
should we tear down the device/bridge/info services? I think so? Everything put together in setup should be freed in my opinion.
| } | ||
|
|
||
| // Resources shared by all tests. | ||
| static cortec::implantapi::CExternalUnitInfo* unitInfo1; |
There was a problem hiding this comment.
can we make these public variables and refer to them in tests as BICBridgeGRPCServiceTests.uintInfo1 (etc)
| // Mock of a IImplantFactory object | ||
| MockIImplantFactory* BICBridgeGRPCServiceTest::mockManager = nullptr; | ||
|
|
||
| TEST_F(BICBridgeGRPCServiceTest, ListBridgesWithoutConnections) { |
There was a problem hiding this comment.
We may(tbd?) need to update this to be TEST_F(BICBridgeGRPCServiceTest theTestEnv, ...) to refer to the testenv to refer to the (now) public variables e.g. unitInfo1.
int myFunct(int x, int y)
{
return x+y;
}
|
|
||
| // Check that when one bridge is connected, scanBridges can be called without any error | ||
| EXPECT_EQ(val.ok(), true); | ||
|
|
There was a problem hiding this comment.
Expect eq(reply->bridge_size(), 1) I think
|
|
||
| // Check that when no bridges are connected, describeBridge can be called without any error | ||
| EXPECT_EQ(val.ok(), true); | ||
|
|
There was a problem hiding this comment.
should check that list is zero length? some other status check?
jeffherron
changed the title
|
Moved back to draft status after student graduated without addressing final comments. |
Add in mock IImplant and IImplantFactory as well as tests for BICBridgeGRPCService