SFTP Backend #16
Merged
SFTP Backend #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial implementation of an SFTP backend for straw.
There was a problem hiding this comment.
Nice to see it's possible to write an in-memory SFTP server nowadays - I remember testing this with a separate docker container with manual key authentication which was an absolute nightmare to get right. This is so much nicer!
Also the server package really should be a standalone thing, I don't know if there is one like it?
Mention sftp in the README
This reinstates the logging test wrapper for the sftp tests to make it match all of the others. This was removed while debugging something and I forgot to put it back.
Use log.Writer() for output, instead of our `debugStream` variable.
Remove comments in the sftp server code that were left in after copying from an example. The comments removed serve mostly to explain how the sftp server library code should be used, we don't need to explain that here.
johanbrandhorst
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of an SFTP backend for straw.