[test] Reduce test input sizes for debug builds with OpenMP in transform_binary.pass
#1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.pass Signed-off-by: Matthew Michel <[email protected]>
…efault) Signed-off-by: Matthew Michel <[email protected]>
mmichel11
requested review from
timmiesmith,
MikeDvorskiy,
dmitriy-sobolev and
danhoeflinger
test/parallel_api/algorithm/alg.modifying.operations/transform_binary.pass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Michel <[email protected]>
Signed-off-by: Matthew Michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform_binary.passwith the OpenMP backend in debug builds has been timing out. This is caused by testing of forward and bidirectional iterators. When no compiler optimization is present, a large number of re-computation of iterators occurs in this line: https://github.com/oneapi-src/oneDPL/blob/66ead74ff6db1eb7e047227086da836531499a74/include/oneapi/dpl/pstl/omp/parallel_for_each.h#L40 which has an expensive cost for iterators without random access. In release builds, there is no problem due to compiler optimization.The test is updated to reduce test sizes in this timeout case. I have also updated our
CMakeLists.txtto set thePSTL_USE_DEBUGmacro for OpenMP builds as well.