Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some TODO in merge and merge_sort algorithms #2027

Closed

Conversation

SergeyKopienko
Copy link
Contributor

@SergeyKopienko SergeyKopienko commented Jan 30, 2025

In this PR we fix some TODO's in merge and merge_sort algorithms:

  • remove hard-coded amount of base diagonals from merge algorithm implementation.

These TODO has been introduced in the PR #1933

@SergeyKopienko SergeyKopienko marked this pull request as draft January 30, 2025 09:25
@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/fix_todo_in_merge_and_merge_sort branch from b2df30d to bb522d4 Compare January 30, 2025 10:03
@SergeyKopienko SergeyKopienko force-pushed the dev/skopienko/fix_todo_in_merge_and_merge_sort branch from 62c116f to 4a268f1 Compare January 30, 2025 10:13
…rge_sort.h - remove threshold data size usage from merge_sort"

This reverts commit c2c64c6.
@SergeyKopienko
Copy link
Contributor Author

Performance degradation detected.

@SergeyKopienko SergeyKopienko deleted the dev/skopienko/fix_todo_in_merge_and_merge_sort branch January 30, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant