[BLAS][HIP] Fix blas support for rocBLAS 4+ #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
approved these changes
Jun 20, 2024
Contributor
Rbiessy
left a comment
Rbiessy
left a comment
There was a problem hiding this comment.
Thanks for the patch, makes sense to me.
andrewtbarker
approved these changes
Jul 9, 2024
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch is similar to #448 (thanks @nilsfriess ) but with only the ifdef part to make the rocBLAS 4 build work.
I've tested with ROCm 5.4.3 (rocBLAS 2), and ROCm 6.1.0 (rocBLAS 4), I've also tested the build with ROCm 5.7.1 (rocBLAS 3), the new interface seemed to cause build issues with rocBLAS 3 so I kept the legacy one.
Information on the deprecated interface here.
Checklist
All Submissions
cc @mmeterel @Rbiessy