Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview macros cleanup #1632

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

kboyarinov
Copy link
Contributor

Description

Remove usages of outdated preview macros TBB_PREVIEW_WAITING_FOR_WORKERS, TBB_PREVIEW_ALGORITHM_TRACE and TBB_PREVIEW_VARIADIC_PARALLEL_INVOKE.
Rename __TBB_PREVIEW_CRITICAL_TASKS to __TBB_CRITICAL_TASKS since it does not represents a preview feature anymore but can be used for internal debugging.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kboyarinov kboyarinov merged commit d68d40b into master Feb 12, 2025
26 checks passed
@kboyarinov kboyarinov deleted the dev/kboyarinov/preview_macros_cleanup branch February 12, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants